Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IO task marker in scheduling #8950

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

jrbourbeau
Copy link
Member

Companion PR to dask/dask#11558 where we incorporate the new io_task attribute into our scheduling logic

@jrbourbeau jrbourbeau added the skip-caching Apply to PRs to disable CI environment caching label Nov 25, 2024
@jrbourbeau jrbourbeau requested a review from fjetter as a code owner November 25, 2024 19:15
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    21 files   -      6      21 suites   - 6   9h 24m 43s ⏱️ - 2h 1m 38s
 4 128 tests +     1   4 011 ✅ +     2    116 💤 +  4  1 ❌  - 5 
39 621 runs   - 12 093  37 715 ✅  - 11 692  1 903 💤  - 396  3 ❌  - 5 

For more details on these failures, see this check.

Results for commit 2514021. ± Comparison against base commit 8f1b241.

This pull request skips 4 tests.
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[Signals.SIGINT]
distributed.cli.tests.test_dask_scheduler ‑ test_signal_handling[Signals.SIGTERM]
distributed.tests.test_client ‑ test_computation_object_code_not_available
distributed.tests.test_scheduler ‑ test_decide_worker_rootish_while_last_worker_is_retiring

♻️ This comment has been updated with latest results.

@jrbourbeau jrbourbeau mentioned this pull request Dec 13, 2024
7 tasks
Comment on lines +5347 to +5348
while not s.tasks:
await asyncio.sleep(0.01)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
while not s.tasks:
await asyncio.sleep(0.01)
await async_poll_for(lambda: s.tasks, 5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-caching Apply to PRs to disable CI environment caching
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants