Display validation errors on DLP for embargoed dandisets #2122
+161
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
added
patch
|
See https://deploy-preview-2122--gui-staging-dandiarchive-org.netlify.app/dandiset/215957 for working example |
jjnesbitt
reviewed
Jan 2, 2025
jjnesbitt
requested changes
Jan 2, 2025
If a dandiset has assets, but they are all in the INVALID status, it will not have an assets summary.
mvandenburgh
force-pushed
the
display-validation-errors-for-embargoed
branch
from
0f5bd72 to
9fcf1dd
Compare
mvandenburgh
force-pushed
the
display-validation-errors-for-embargoed
branch
from
9fcf1dd to
92f9567
Compare
jjnesbitt
approved these changes
Jan 3, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2089.
We currently don't display validation errors on the DLP for embargoed dandisets. This seems to be an oversight due to much of the UI being duplicated between the
DandisetPublishandDandisetUnembargocomponents. I've taken an initial stab at refactoring some of the duplicate templates into a reusable component in this PR, but we could probably clean it up a bit more.The text displayed when the Assets Summary is missing (
This Dandiset does not contain any assets.) is also slightly misleading. A dandiset that contains only invalid assets will also not have an Assets Summary; I've updated that text to reflect that.