Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding blogs to crio.io #62

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Adding blogs to crio.io #62

wants to merge 9 commits into from

Conversation

siddharth-sable
Copy link

Closes [cri-o/cri-o#7276]

@openshift-ci openshift-ci bot requested review from rhatdan and umohnani8 September 21, 2023 21:58
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Sep 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: siddharth-sable
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siddharth-sable
Copy link
Author

/release-note-none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 22, 2023
@saschagrunert
Copy link
Member

@siddharth-sable can you please DCO sign-off your commit using git commit --amend --no-edit -s && git push -f?

Slach and others added 9 commits March 11, 2024 23:50
@Slach @siddharth-sable
update Ubuntu installation instruction
deb6059 
Signed-off-by: Slach <[email protected]>
@haircommander @siddharth-sable
update installation instructions
ac9ee96 
Signed-off-by: Peter Hunt <[email protected]>
@TomSweeneyRedHat @siddharth-sable
Fix two home page nits
39990b7 
We've a bad link to the conmon GitHub repo, that repairs that.  It was also
pointed out that we've not posted a blog to the medium/crio site in over two
years, this comments the link to that out.  If more blogs are added there (Yes Please!), then we can turn that back on.

Addresses: cri-o#46
Addresses: cri-o#48

Signed-off-by: TomSweeneyRedHat <[email protected]>
@dgl @siddharth-sable
Remove IRC, make it easier to find Slack
92b7fe7 
Signed-off-by: David Leadbeater <[email protected]>
@kamil-stc @siddharth-sable
Fix install urls cri-o/cri-o#6401
1840c1c 
Signed-off-by: Kamil Krzywicki <[email protected]>
@dominic-p @siddharth-sable
Update available Debian versions
b829e84 
The old versions are not actually available on OBS as of June 2023

See cri-o/cri-o#7072

Signed-off-by: Dominic <[email protected]>
@dominic-p @siddharth-sable
Add Debian 12 to the list of supported OSes
20ce342 
See cri-o/cri-o#7072

Signed-off-by: Dominic <[email protected]>
@mrunalp @siddharth-sable
Add license info and graduated status
277ea0a 
Signed-off-by: Mrunal Patel <[email protected]>
@siddharth-sable
Adding blogs to crio.io
1e09d5e 
Closes [cri-o/cri-o#7276]
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@siddharth-sable
Copy link
Author

Hello @saschagrunert, I tried git commit --amend --no-edit -s && git push -f but there was still one commit which was not signed, so I tried to interactively rebase and edit those but I messed up 🥲. Will there be any work around to clean this up?

@saschagrunert
Copy link
Member

saschagrunert commented Mar 12, 2024 •
edited
Loading

@siddharth-sable give a git rebase -i master a try and squash (S) the commits together. Then force (-f) push.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees
No one assigned
Labels
dco-signoff: no Indicates the PR's author has not DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@siddharth-sable @saschagrunert @openshift-merge-robot @Slach @haircommander @TomSweeneyRedHat @dgl @kamil-stc @dominic-p @mrunalp