Con duct ls #224
Draft
Con duct ls #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Nov 12, 2024
yarikoptic
reviewed
Nov 12, 2024
yarikoptic
reviewed
Nov 12, 2024
yarikoptic
reviewed
Nov 12, 2024
yarikoptic
reviewed
Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 95.36% 92.43% -2.94%
==========================================
Files 4 5 +1
Lines 626 661 +35
Branches 70 76 +6
==========================================
+ Hits 597 611 +14
- Misses 15 36 +21
Partials 14 14 ☔ View full report in Codecov by Sentry. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "./.update-readme-help.py",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
reviewed
Dec 3, 2024
Comment on lines
+41
to
+45
| print( | ||
| f"Unexpected format encountered: {args.format}. This should have been caught by argparse.", | ||
| file=sys.stderr, | ||
| ) | ||
| return 1 |
There was a problem hiding this comment.
smells like a logical place to raise RuntimeError if it is something unexpected. hence
Suggested change
| print( | |
| f"Unexpected format encountered: {args.format}. This should have been caught by argparse.", | |
| file=sys.stderr, | |
| ) | |
| return 1 | |
| raise RuntimeError( | |
| f"Unexpected format encountered: {args.format}. This should have been caught by argparse.", | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185
summaries
yaml
json
{"command": "sleep 0.11", "system": {"cpu_total": 20, "memory_total": 33336127488, "hostname": "fancy", "uid": 1000, "user": "austin"}, "env": {}, "gpu": null, "duct_version": "0.8.0", "schema_version": "0.2.0", "execution_summary": {"exit_code": 0, "command": "sleep 0.11", "logs_prefix": ".duct/logs/2024.11.11T22.17.33-130359_", "wall_clock_time": 0.11228775978088379, "peak_rss": 1961984, "average_rss": 1961984, "peak_vsz": 232374272, "average_vsz": 232374272, "peak_pmem": 0.0, "average_pmem": 0.0, "peak_pcpu": 0.0, "average_pcpu": 0.0, "num_samples": 1, "num_reports": 2, "start_time": 1731385053.198443, "end_time": 1731385053.3107307}, "output_paths": {"stdout": ".duct/logs/2024.11.11T22.17.33-130359_stdout", "stderr": ".duct/logs/2024.11.11T22.17.33-130359_stderr", "usage": ".duct/logs/2024.11.11T22.17.33-130359_usage.json", "info": ".duct/logs/2024.11.11T22.17.33-130359_info.json", "prefix": ".duct/logs/2024.11.11T22.17.33-130359_"}} {"command": "sleep 0.1", "system": {"cpu_total": 20, "memory_total": 33336127488, "hostname": "fancy", "uid": 1000, "user": "austin"}, "env": {}, "gpu": null, "duct_version": "0.8.0", "schema_version": "0.2.0", "execution_summary": {"exit_code": 0, "command": "sleep 0.1", "logs_prefix": ".duct/logs/2024.11.11T22.17.36-130380_", "wall_clock_time": 0.10244536399841309, "peak_rss": 1978368, "average_rss": 1978368, "peak_vsz": 232374272, "average_vsz": 232374272, "peak_pmem": 0.0, "average_pmem": 0.0, "peak_pcpu": 0.0, "average_pcpu": 0.0, "num_samples": 1, "num_reports": 2, "start_time": 1731385056.3133166, "end_time": 1731385056.415762}, "output_paths": {"stdout": ".duct/logs/2024.11.11T22.17.36-130380_stdout", "stderr": ".duct/logs/2024.11.11T22.17.36-130380_stderr", "usage": ".duct/logs/2024.11.11T22.17.36-130380_usage.json", "info": ".duct/logs/2024.11.11T22.17.36-130380_info.json", "prefix": ".duct/logs/2024.11.11T22.17.36-130380_"}}jsonpp
{'command': 'sleep 0.11', 'duct_version': '0.8.0', 'env': {}, 'execution_summary': {'average_pcpu': 0.0, 'average_pmem': 0.0, 'average_rss': 1961984, 'average_vsz': 232374272, 'command': 'sleep 0.11', 'end_time': 1731385053.3107307, 'exit_code': 0, 'logs_prefix': '.duct/logs/2024.11.11T22.17.33-130359_', 'num_reports': 2, 'num_samples': 1, 'peak_pcpu': 0.0, 'peak_pmem': 0.0, 'peak_rss': 1961984, 'peak_vsz': 232374272, 'start_time': 1731385053.198443, 'wall_clock_time': 0.11228775978088379}, 'gpu': None, 'output_paths': {'info': '.duct/logs/2024.11.11T22.17.33-130359_info.json', 'prefix': '.duct/logs/2024.11.11T22.17.33-130359_', 'stderr': '.duct/logs/2024.11.11T22.17.33-130359_stderr', 'stdout': '.duct/logs/2024.11.11T22.17.33-130359_stdout', 'usage': '.duct/logs/2024.11.11T22.17.33-130359_usage.json'}, 'schema_version': '0.2.0', 'system': {'cpu_total': 20, 'hostname': 'fancy', 'memory_total': 33336127488, 'uid': 1000, 'user': 'austin'}} {'command': 'sleep 0.1', 'duct_version': '0.8.0', 'env': {}, 'execution_summary': {'average_pcpu': 0.0, 'average_pmem': 0.0, 'average_rss': 1978368, 'average_vsz': 232374272, 'command': 'sleep 0.1', 'end_time': 1731385056.415762, 'exit_code': 0, 'logs_prefix': '.duct/logs/2024.11.11T22.17.36-130380_', 'num_reports': 2, 'num_samples': 1, 'peak_pcpu': 0.0, 'peak_pmem': 0.0, 'peak_rss': 1978368, 'peak_vsz': 232374272, 'start_time': 1731385056.3133166, 'wall_clock_time': 0.10244536399841309}, 'gpu': None, 'output_paths': {'info': '.duct/logs/2024.11.11T22.17.36-130380_info.json', 'prefix': '.duct/logs/2024.11.11T22.17.36-130380_', 'stderr': '.duct/logs/2024.11.11T22.17.36-130380_stderr', 'stdout': '.duct/logs/2024.11.11T22.17.36-130380_stdout', 'usage': '.duct/logs/2024.11.11T22.17.36-130380_usage.json'}, 'schema_version': '0.2.0', 'system': {'cpu_total': 20, 'hostname': 'fancy', 'memory_total': 33336127488, 'uid': 1000, 'user': 'austin'}}TODO