Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unload_models" flag when creating a task #6204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bigcat88
Copy link
Contributor

When might this be needed:

  1. When you have a heavy workflow and want to run it in clean environment.
  2. When several people use a server with Comfy and pressing the "Clear memory" button in the front-end does not guarantee that at that moment someone else will not add a task before yours.
  3. For use via API, for example, you have a server with Comfy and you want to measure how many memory are consumed by the workflow - you will also need this flag then, because if the server is not purely for testing, but in production - see point 2.
  4. For clear and easy benchmarks using API.

We use something similar in our project, but since now we want to reduce the amount of different code between us and Comfy, I hope this PR will be accepted.

If I need to update the documentation somewhere - point your finger..

P.S: about point 3, to save info about how many memory are consumed by the workflow - if such feature is needed for someone I can create a separate PR.

@ltdrdata ltdrdata added the Good PR This PR looks good to go, it needs comfy's final review. label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good PR This PR looks good to go, it needs comfy's final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants