schemachanger: Fixed bug incorrect InvertedColumnKinds in the inverte…

[Dedej-Bergin]

…d index

Previously the SHOW CREATE TABLE statement would lose index information. The fix now allows SHOW CREATE TABLE to show the correct information that can be repeatedly entered back into crdb to recreate the same table.

Fixes: #136410
Release note (bug fix): Previously SHOW CREATE TABLE was showing incorrect data with regards to inverted indexes. It now shows the correct data that can be repeatedly entered back into crdb to recreate the same table.

[cockroach-teamcity]

This change is 

[rafiss]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Dedej-Bergin)

---

pkg/sql/logictest/testdata/logic_test/show_create line 247 at r1 (raw file):

statement ok
CREATE TABLE roaches (id UUID PRIMARY KEY, x STRING, y STRING);

Logic tests have a hook that adds random column families to CREATE TABLE statements. That's why the SHOW CREATE output below has extra lines for FAMILY. To make the test stable, we need to add an explicit column family definition here. The test cases above this one do that too.

So this should be:

CREATE TABLE roaches (id UUID PRIMARY KEY, x STRING, y STRING, FAMILY f1 (id, x, y));

---

pkg/sql/logictest/testdata/logic_test/show_create line 248 at r1 (raw file):

statement ok
CREATE TABLE roaches (id UUID PRIMARY KEY, x STRING, y STRING);
CREATE INDEX ON roaches USING GIN (x, y gin_trgm_ops);

I ran this test with your change in pkg/sql/schemachanger/scexec/scmutationexec/index.go reverted, and it still passed

i think it's because the statements are sent as a batch, which causes them all the run in one transaction, which means the legacy schema changer will be used. so we need to separate them:

statement ok
CREATE TABLE roaches (id UUID PRIMARY KEY, x STRING, y STRING, FAMILY f1 (id, x, y));

statement ok
CREATE INDEX ON roaches USING GIN (x, y gin_trgm_ops);

[rafiss]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Dedej-Bergin)

---

pkg/sql/logictest/testdata/logic_test/show_create line 248 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

I ran this test with your change in pkg/sql/schemachanger/scexec/scmutationexec/index.go reverted, and it still passed

i think it's because the statements are sent as a batch, which causes them all the run in one transaction, which means the legacy schema changer will be used. so we need to separate them:

statement ok
CREATE TABLE roaches (id UUID PRIMARY KEY, x STRING, y STRING, FAMILY f1 (id, x, y));

statement ok
CREATE INDEX ON roaches USING GIN (x, y gin_trgm_ops);

As a more general tip, whenever you make a bug fix and add a test for it, you should always make sure the test fails without your bug fix.

[Dedej-Bergin]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/sql/logictest/testdata/logic_test/show_create line 247 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

Logic tests have a hook that adds random column families to CREATE TABLE statements. That's why the SHOW CREATE output below has extra lines for FAMILY. To make the test stable, we need to add an explicit column family definition here. The test cases above this one do that too.

So this should be:

CREATE TABLE roaches (id UUID PRIMARY KEY, x STRING, y STRING, FAMILY f1 (id, x, y));

Thanks Rafi! Just made this change.

---

pkg/sql/logictest/testdata/logic_test/show_create line 248 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

As a more general tip, whenever you make a bug fix and add a test for it, you should always make sure the test fails without your bug fix.

Thanks Rafi! I went ahead and made this change, thanks for the tip!

[rafiss]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Dedej-Bergin)

[Dedej-Bergin]

TFTR!

bors r+

[craig]

Build succeeded:

• lint
• local_roachtest
• linux_arm64_build
• acceptance
• macos_amd64_build
• linux_amd64_fips_build
• macos_arm64_build
• check_generated_code
• windows_build
• examples_orms
• docker_image_amd64
• unit_tests
• linux_amd64_build
• local_roachtest_fips

[rafiss]

blathers backport 24.3 24.2 24.1 23.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from c902275 to blathers/backport-release-24.1-138043: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1 failed. See errors above.

---

error creating merge commit from c902275 to blathers/backport-release-23.2-138043: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}