sql/schemachanger: remove DROP INDEX fallbacks for regional by row #137989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rafiss
force-pushed
the
dsc-check-region-change-underway
branch
from
7050ed7 to
0f7112b
Compare
rafiss
changed the title
rafiss
force-pushed
the
dsc-check-region-change-underway
branch
from
0f7112b to
bfb23e4
Compare
rafiss
changed the title
rafiss
force-pushed
the
dsc-check-region-change-underway
branch
from
bfb23e4 to
70bd5e6
Compare
rafiss
requested review from
kev-cao and
annrpom
and removed request for
a team
annrpom
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
thank you for doing this!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kev-cao and @rafiss)
pkg/sql/catalog/multiregion/region_util.go line 90 at r2 (raw file):
o SynthesizeRegionConfigOptions, ) (RegionConfig, error) { // move below stuff to multiregion/region_util.go
leftover comment
This commit moves function and type definitions to a smaller package so the declarative schema changer can use it. Release note: None
This adds SynthesizeRegionConfig to the RegionProvider interface so that the scbuild package can use it. Release note: None
This commit introduces a new function that will fail a schema change if the table is regional by row and if any of the regions for the database are currently being modified. With this new check, we no longer need to fallback to the legacy schema changer for DROP INDEX. Previously we had to, since this check was only implemented there. This check was also added for ALTER PRIMARY KEY, CREATE INDEX, ADD COLUMN, and DROP COLUMN, but the regional-by-row fallback still exists for those operations. Release note: None
rafiss
force-pushed
the
dsc-check-region-change-underway
branch
from
70bd5e6 to
42b9060
Compare
rafiss
commented
Dec 30, 2024
There was a problem hiding this comment.
tftr!
bors r+
Reviewable status:
pkg/sql/catalog/multiregion/region_util.go line 90 at r2 (raw file):
Previously, annrpom (annie pompa) wrote…
leftover comment
fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catalog/multiregion: move SynthesizeMultiregionConfig function
This commit moves function and type definitions to a smaller package so
the declarative schema changer can use it.
sql/regions: extract SynthesizeRegionConfig into interface
This adds SynthesizeRegionConfig to the RegionProvider interface so that
the scbuild package can use it.
sql/schemachanger: remove DROP INDEX fallbacks for regional by row
This commit introduces a new function that will fail a schema change if
the table is regional by row and if any of the regions for the database
are currently being modified. With this new check, we no longer need to
fallback to the legacy schema changer for DROP INDEX. Previously we had
to, since this check was only implemented there.
This check was also added for ALTER PRIMARY KEY, CREATE INDEX, ADD COLUMN,
and DROP COLUMN, but the regional-by-row fallback still exists for those
operations.
fixes #136320
Release note: None