-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mini launch bash #2852
base: master
Are you sure you want to change the base?
Mini launch bash #2852
Conversation
….24, clink-completions v0.4.7)
Updates to `3` vendored dependencies
@@ -31,3 +31,10 @@ launcher/src/version.rc2 | |||
.vs/* | |||
.vscode | |||
.idea | |||
.vagrant/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to move some of the gitignores here to the Vagrant + Packer branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is my opinion this vranch should be merged with master. I see no reason to maintain a second branch.
LGTM! 👍 I haven't tested the ConEmu changes yet though, but it looks alright to me. Thank you Dax! |
Its nice because Cmder mini can actually launch bash if git for windows is installed in a well known location. |
Changes
Bash::Git bash
andBash::Git bash as Admin
use a script to find and launch Git Bash from the following locations if they exist:%CMDER_ROOT%\vendor\git-for-Windows
%Program Files%\Git
Adds
%Program Files%\Git
Bash::mintty - External
Bash::mintty as Admin - External