Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini launch bash #2852

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Mini launch bash #2852

wants to merge 10 commits into from

Conversation

daxgames
Copy link
Member

@daxgames daxgames commented Jun 5, 2023

Changes

  • Bash::Git bash and Bash::Git bash as Admin use a script to find and launch Git Bash from the following locations if they exist:
    1. %CMDER_ROOT%\vendor\git-for-Windows
    2. %Program Files%\Git
    3. %Program Files(x86)%\Git`

Adds

  • New Default Tasks to launch Bash using MinTTY from %Program Files%\Git
    • Bash::mintty - External

    • Bash::mintty as Admin - External

      image

@daxgames daxgames requested a review from DRSDavidSoft June 5, 2023 20:53
@daxgames daxgames marked this pull request as draft June 6, 2023 13:55
@DRSDavidSoft DRSDavidSoft added 🎨 Type: Enhancement 👆 Git Upstream issue in Git for Windows. labels Jun 6, 2023
@daxgames daxgames marked this pull request as ready for review July 4, 2023 17:10
@@ -31,3 +31,10 @@ launcher/src/version.rc2
.vs/*
.vscode
.idea
.vagrant/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to move some of the gitignores here to the Vagrant + Packer branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my opinion this vranch should be merged with master. I see no reason to maintain a second branch.

@DRSDavidSoft
Copy link
Contributor

LGTM! 👍 I haven't tested the ConEmu changes yet though, but it looks alright to me. Thank you Dax!

@daxgames
Copy link
Member Author

daxgames commented Jul 5, 2023

Its nice because Cmder mini can actually launch bash if git for windows is installed in a well known location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 Git Upstream issue in Git for Windows. 🎨 Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants