fix: use fixed event listeners to address race conditions #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc86a6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chrisvxd
commented
Dec 12, 2024
Comment on lines
+108
to
+119
| for (const draggable of this.manager.registry.draggables.value) { | ||
| if (draggable.element) { | ||
| documents.add(getDocument(draggable.element)); | ||
| } | ||
| } | ||
|
|
||
| for (const droppable of this.manager.registry.droppables.value) { | ||
| if (droppable.element) { | ||
| documents.add(getDocument(droppable.element)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Noting that this may be better elsewhere for perf reasons
chrisvxd
commented
Dec 12, 2024
Comment on lines
+218
to
+221
| // Event may have duplicated between documents if user is bubbling events | ||
| if (doc !== ownerDocument) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Note, new safe-guard to account for an edge-case where the user bubbles the pointermove event to the parent document (as I am doing with Puck).
I can address this on my end, but a safe-guard seemed sensible.
74 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the PointerSensor to use fixed event listeners, rather than dynamic ones, preventing race conditions that can occur if the document changed during drag, such as when dragging across frames.
To reproduce, rapidly drag items from the host to the iframe in the iframe stories.