Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether portable is directory to avoid conflict with portable sandboxing framework #1445

Closed
wants to merge 1 commit into from

Conversation

heavysink
Copy link

@heavysink heavysink commented Dec 9, 2024

Portable sandboxing framework adds an executable called "portable" which may confuse the portable configuration check of cemu. Fix #1444

@capitalistspz
Copy link
Contributor

Given the issue you raised, a more resilient solution would be to add a build flag, so that package makers can disable portable mode. Otherwise the next problem might be that there's a package that creates a portable directory for some other purpose

@goeiecool9999
Copy link
Collaborator

a more resilient solution would be to add a build flag

Which cemu used to have. 9bbb7c8 deliberately removed the build flag and let Cemu determine if it should run portably at runtime. I personally prefer this. Maybe a reasonable compromise would be to add an overriding command line argument?

@capitalistspz
Copy link
Contributor

Determining whether to run portably at runtime can still be done, the flag can be used to prevent Cemu from being allowed to decide at runtime.

There's a problem with using a command line argument, being that you'd have to set it every time you ran Cemu from the command line

@goeiecool9999
Copy link
Collaborator

Determining whether to run portably at runtime can still be done, the flag can be used to prevent Cemu from being allowed to decide at runtime.

Sounds good to me. I figured that's probably what you meant after I already posted my reply.

@Exzap
Copy link
Member

Exzap commented Dec 30, 2024

Superseded by #1464

@Exzap Exzap closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants