Enchanced checks #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arno
suggested changes
Aug 30, 2017
route/route.go
Outdated
| client, err := ssh.Dial("tcp", hostport, ssh_config) | ||
| if err != nil { | ||
| re_auth_failure := regexp.MustCompile(`handshake failed: ssh: unable to authenticate`) | ||
| if re_auth_failure.MatchString(err.Error()) { |
There was a problem hiding this comment.
It would be better to merge the two lines i.e. regexp.MustCompile(...).MatchString(...).
| chosen_item-- | ||
| } | ||
| } else { | ||
| return "", errors.New("No proxied connections, unable to pick a random user..") |
| @@ -165,10 +166,41 @@ func (hc *hostChecker) DoCheck(hostport string) State { | |||
| if route.CanConnect(hostport) { | |||
| state = Up | |||
| } | |||
| canary_user, err := PickUser() | |||
arno
reviewed
Sep 13, 2017
| "time" | ||
|
|
||
| "github.com/op/go-logging" | ||
|
|
||
| "golang.org/x/crypto/ssh" |
There was a problem hiding this comment.
Use glide to manage this new dependency.
fihuer
force-pushed
the
enchanced_checks
branch
2 times, most recently
from
f9f001f to
18401ec
Compare
arno
force-pushed
the
enchanced_checks
branch
2 times, most recently
from
1940be1 to
fe6017b
Compare
arno
suggested changes
Jul 5, 2018
| hc.Update(hostport, state, time.Now()) | ||
| return state | ||
| } | ||
|
|
||
| func pickUser() (string, error) { |
Instead of just checking if a port is reachable we try to connect to the SSH server using an already connected user.
cyrilst
force-pushed
the
master
branch
6 times, most recently
from
7ca0082 to
6d3fa42
Compare
cyrilst
force-pushed
the
master
branch
2 times, most recently
from
dd3157a to
ddf56a4
Compare
cyrilst
force-pushed
the
master
branch
7 times, most recently
from
64c8f1a to
9931db0
Compare
cyrilst
force-pushed
the
master
branch
3 times, most recently
from
1f35892 to
62fe770
Compare
cyrilst
force-pushed
the
master
branch
2 times, most recently
from
fb62b12 to
a6f0cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1