Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the app config on startup #206

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

smcmurtry
Copy link
Contributor

@smcmurtry smcmurtry commented Dec 24, 2024

Summary | Résumé

This commit makes the following changes:

  • the config values are now logged when the app starts up, with sensitive values masked
  • this is implemented as new class methods on the existing Config class
  • new tests added to verify this is working correctly
  • add the environs package to force the DEBUG config value to be boolean

This PR shamelessly copies what @patheard did over in this pr to implement the same feature in notification-api.

Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/504

Test instructions | Instructions pour tester la modification

Test locally to ensure you can see the config values being logged.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

@smcmurtry smcmurtry marked this pull request as ready for review December 27, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants