chore: update devcontainer to share same network as api/admin #199
Conversation
| version: '3' | ||
| services: | ||
| # Update this to the name of the service you want to work with in your docker-compose.yml file | ||
| notify-ddapi: |
There was a problem hiding this comment.
It works as is? i.e. you didn't have to define a service attribute in the devcontainer.json file? (I didn't try without it -- I guess it assumes it and use it correctly).
There was a problem hiding this comment.
Yeah it did work fine, but I didnt realize that was over there. I will look more closely at the other repos and make this match. Its too bad there is linting on these type of files since there are clearly dependencies between them!
| # Overrides default command so things don't shut down after the process ends. | ||
| command: sleep infinity | ||
| expose: | ||
| - "7000" |
There was a problem hiding this comment.
Did you check if there was a conflict with port 7000 when bringing up this devcontainer into vscode? It is possible there might be a conflict and a new port from 7000->random port might get created. In the API, we removed the forward port in devcontainer.json if I am not mistaken.
There was a problem hiding this comment.
I'll take a look. It all worked fine when I rebuilt the container so I assumed it was OK.
There was a problem hiding this comment.
Removing the forwarded port section makes it not work at all 🤷
There was a problem hiding this comment.
Added it back, its all working locally now. Did you want to try it out before I merge?
Summary | Résumé
This PR updates the repo's devcontainer, modeled after the one in notification-admin.
It adds a network named
notify-networkthat each component will use to communicate locally.Test instructions | Instructions pour tester la modification
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur