perf: preload font #152
Open
perf: preload font #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@realguse is attempting to deploy a commit to the catppuccin Team on Vercel. A member of the Team first needs to authorize it. |
|
I can't quite remember @unseen-ninja, was there an intentional reason for why we didn't do this from the beginning? |
|
Yesn't. Iirc it all came down to first-paint-time where preloading the font delayed it quite a bit. But personally I don't mind it either way – tho I still think shipping a font is overrated. :^) Happy to have this merged. c: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@unseen-ninja you think we should just use the system fonts and do something like this: font-family: ui-sans-serif, system-ui, sans-serif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the font performance and remove the layout-shifting on the website.
Layout shifting (when refreshing):
Screen.Recording.2024-12-27.at.8.43.00.PM.mov