Bump gocql version to v1.7.0 #6511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantas-sidlauskas
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
mantas-sidlauskas
force-pushed
the
gocql_version2
branch
from
7e24985 to
a338232
Compare
mantas-sidlauskas
force-pushed
the
gocql_version2
branch
from
e9c04db to
10ff970
Compare
shijiesheng
reviewed
Dec 23, 2024
Groxx
reviewed
Dec 24, 2024
Comment on lines
+92
to
+97
|
|
||
| // even if null is stored in cassandra, gocql will return empty struct instead of nil | ||
| if version == 0 && numRead == 0 && numWrite == 0 { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm kinda assuming this is a change in behavior? I don't really see it in the changelog, but I might just lack gocql-context / keyword-guessing-ability to find it: https://github.com/apache/cassandra-gocql-driver/blob/trunk/CHANGELOG.md
If this is a broad "was null -> now empty struct" change, we'll probably have to do this kinda carefully :\ and/or wrap gocql and convert it everywhere, if that's possible. seems like the sort of change that'd cause a lot of minor and hard-to-notice bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Bumping gocql to the newest release
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes