Remove legacy doctor command
#966
Merged
+1
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcwhite
temporarily deployed
to
remove-doctor-command - bridgetown-beta PR #966
Render
Destroyed
jaredcwhite
temporarily deployed
to
remove-doctor-command - bridgetown-api PR #966
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #867
I decided to remove the command, it really isn't serving much of a purpose and I don't even like the name
doctorwhich implies it will fix your issues but it only diagnoses.Probably a better plan in the future is to build a
diagnosticscommand which can surface interesting stats, highlight possible performance issues, and offer suggested fixes for any major issues.