Add ArrayVecCopy V2 #261
Open
Add ArrayVecCopy V2 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Unfortunately miri says there is UB in quite a few places. Tests with UB are:
After trying for a bit I am not going to fix this UB myself. I am not proficient enough with unsafe yet. |
tbu-
reviewed
Oct 16, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "arrayvec" | |||
| version = "0.7.4" | |||
| version = "0.8.0" | |||
There was a problem hiding this comment.
I don't see a breaking change. Is there any?
| @@ -42,6 +42,7 @@ harness = false | |||
| [features] | |||
| default = ["std"] | |||
| std = [] | |||
| copy = [] | |||
There was a problem hiding this comment.
I don't think it's necessary to gate this behind a feature.
| mod arrayvec_copy; | ||
| #[cfg(feature = "copy")] | ||
| pub mod copy { | ||
| pub use crate::arrayvec_copy::{ArrayVecCopy, IntoIter, Drain}; |
There was a problem hiding this comment.
Perhaps only keep the iterator types in here and expose the ArrayVecCopy globally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of closed: #193
Made a copy of ArrayVec (ArrayVecCopy) that can only hold Copy items.
This means copying all of its relevant functions and relevant tests.
Closes #32