Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: improve /list performance (#3663) #4102

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 3, 2025

Replaces #3663

Segments are now parsed in parallel.

Segments are now parsed in parallel.
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 80.82192% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.16%. Comparing base (ac0ddc9) to head (a8ee1fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/playback/on_list.go 79.41% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4102      +/-   ##
==========================================
+ Coverage   56.11%   56.16%   +0.05%     
==========================================
  Files         199      199              
  Lines       20539    20567      +28     
==========================================
+ Hits        11525    11552      +27     
  Misses       8144     8144              
- Partials      870      871       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 21b5031 into main Jan 3, 2025
8 checks passed
@aler9 aler9 deleted the feature/list-parallel branch January 3, 2025 12:59
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This issue is mentioned in release v1.11.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant