playback: improve /list response time (#3637) #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4096 +/- ##
==========================================
- Coverage 56.15% 56.12% -0.03%
==========================================
Files 199 199
Lines 20464 20539 +75
==========================================
+ Hits 11492 11528 +36
- Misses 8114 8141 +27
- Partials 858 870 +12 ☔ View full report in Codecov by Sentry. |
aler9
force-pushed
the
feature/list-performance
branch
2 times, most recently
from
274d9d3 to
a58b39e
Compare
This was referenced Jan 2, 2025
aler9
force-pushed
the
feature/list-performance
branch
4 times, most recently
from
9959ea7 to
16e5e85
Compare
Response times of the /list endpoint were slow because the duration of each segment was computed from scratch by summing the duration of each of its parts. This is improved by storing the duration of the overall segment in the header and using that, if available.
aler9
force-pushed
the
feature/list-performance
branch
from
16e5e85 to
501b614
Compare
|
This issue is mentioned in release v1.11.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response times of the /list endpoint were slow because the duration of each segment was computed from scratch by summing the duration of each of its parts.
This is improved by storing the duration of the overall segment in the header and using that, if available.