Return with failure if we can't resolve hostname to address #4874
Conversation
aakash10292
force-pushed
the
aar_resolve_hn_failure
branch
from
0725dc0 to
e736a9e
Compare
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
aakash10292
force-pushed
the
aar_resolve_hn_failure
branch
2 times, most recently
from
d58eea6 to
2e8c478
Compare
|
/plugin-branch aar_resolve_failure |
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/589 tests failed ⚠.
The first 10 failing tests are:
sc_remsql [setup failure]
osql_cleanup
snap_ha_retry_newsi_generated
tunables
ssl_remsql_fdbpushredirect_generated
auth
Signed-off-by: Aakash Arayambeth <[email protected]>
aakash10292
force-pushed
the
aar_resolve_hn_failure
branch
from
2e8c478 to
eefcff3
Compare
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/591 tests failed ⚠.
The first 10 failing tests are:
sc_lotsoftables [setup failure]
lock_views [setup failure]
selectv_recom [setup failure]
fdb_push_rte_connect_generated [setup failure]
systable_locking
phys_rep_perf
timepart_trunc_serialsc_generated
snap_ha_retry_newsi_generated
This addresses the failure observed while deploying version 8.1.
The error was triggered by a DNS failure, which resulted in a failure to look up a speciic hostname (obtained by a nodenum lookup) while processing the "cluster nodes" line.
This failure results in the nodenum being added as the hostname, which pollutes the cluster information across the cluster.
This patch (and the associated plugin-branch) address these issues.
Since this is a change to plugins, I will add a test to the robomark testsuite, to test this patch.