Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow individual shards to be analyzed through sql + analyze time partitions #4805

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aakash10292
Copy link
Contributor

@aakash10292 aakash10292 commented Oct 31, 2024

Handy in a tight spot, especially since comdb2sc.tsk is going away .

Edit: scope expanded to support 'ANALYZE tpt_name'


SHARDNAME=$(${CDB2SQL_EXE} -tabs ${CDB2_OPTIONS} ${DBNAME} default "select shardname from comdb2_timepartshards where name='t' limit 1")

${CDB2SQL_EXE} ${CDB2_OPTIONS} ${DBNAME} default "ANALYZE \"$SHARDNAME\""
Copy link
Contributor

@akshatsikarwar akshatsikarwar Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the example above, can you make this work: ANALYZE t?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I'll update the test to verify that "Analyze t" works

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/586 tests failed ⚠.

The first 10 failing tests are:
comdb2sys_queueodh_generated [setup failure]
writes_remsql_names_rte_connect_generated [setup failure]
verify_error [setup failure]
sc_transactional_rowlocks_generated
analyze_partial_index_off_generated
analyze
mem_protobuf
snap_ha_retry_newsi_generated

@aakash10292 aakash10292 changed the title allow individual shards to be analyzed through sql allow individual shards to be analyzed through sql + analyze time partitions Nov 6, 2024
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

@aakash10292 aakash10292 force-pushed the aar_analyze_tpt_sql branch 2 times, most recently from 53b3f4e to 03f5422 Compare November 12, 2024 22:02
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 141/586 tests failed ⚠.

The first 10 failing tests are:
sc_redo_logicalsc_generated [setup failure]
sc_dups_logicalsc_generated [setup failure]
siasofupdate [setup failure]
sc_truncate
sc_transactional_rowlocks_generated
analyze_partial_index_off_generated
analyze
analyze_exit_immediately
incoherent_slow
snap_ha_retry_newsi_generated

@aakash10292 aakash10292 force-pushed the aar_analyze_tpt_sql branch 2 times, most recently from 87db73e to 26217b4 Compare November 14, 2024 20:23
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 8/586 tests failed ⚠.

The first 10 failing tests are:
sc_lotsoftables_logicalsc_generated [setup failure]
writes_remsql_fdbpush_generated [setup failure]
verify_error_partial_index_off_generated [setup failure]
ssl_remsql [setup failure]
analyze_exit_immediately
analyze_partial_index_off_generated
analyze
snap_ha_retry_newsi_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/586 tests failed ⚠.

The first 10 failing tests are:
leakcheck [setup failure]
basic [setup failure]
analyze
analyze_partial_index_off_generated
snap_ha_retry_newsi_generated

@aakash10292 aakash10292 force-pushed the aar_analyze_tpt_sql branch 3 times, most recently from e00a30c to 912cf6c Compare November 18, 2024 22:11
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 225/586 tests failed ⚠.

The first 10 failing tests are:
lostwrite [setup failure]
timepart_retention1 [setup failure]
sc_inserts_logicalsc_generated [setup failure]
insert_lots_ssl_generated [setup failure]
comdb2sys [setup failure]
sc_truncate_multiddl_generated
phys_rep_tiered
analyze_partial_index_off_generated
analyze
snap_ha_retry_newsi_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/586 tests failed ⚠.

The first 10 failing tests are:
timepart_retention1 [setup failure]
sc_inserts_logicalsc_generated [setup failure]
misstable_remsql_rte_connect_generated [setup failure]
logfill_logput_window_generated
phys_rep_tiered_nosource_generated
analyze
snap_ha_retry_newsi_generated
ssl_remsql

@aakash10292 aakash10292 force-pushed the aar_analyze_tpt_sql branch 2 times, most recently from eb52a66 to 37eabce Compare December 5, 2024 21:47
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 113/591 tests failed ⚠.

The first 10 failing tests are:
incremental_backup_load [setup failure]
sc_truncate [setup failure]
analyze [setup failure]
sc_tableversion_logicalsc_generated [setup failure]
constraints [setup failure]
sc_remsql_fdbpush_generated [setup failure]
sc_remsql [setup failure]
sc_transactional_rowlocks_generated
phys_rep_perf
analyze_partial_index_off_generated

Signed-off-by: Aakash Arayambeth <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/591 tests failed ⚠.

The first 10 failing tests are:
incoh_remsql [setup failure]
autoanalyze [setup failure]
selectv_range [setup failure]
rowlock_update [setup failure]
union_parallel [setup failure]
logfill
phys_rep_perf
snap_ha_retry_newsi_generated
dbcreate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants