Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop optional pyarrow for pandas 3.x #1178

Merged
merged 2 commits into from
Oct 28, 2024
Merged

drop optional pyarrow for pandas 3.x #1178

merged 2 commits into from
Oct 28, 2024

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Oct 28, 2024

🚀 Pull Request

Description

This pull-request drops the optional pyarrow package.

This package was only added to remove the following DeprecationWarning being issued by pandas 2.2.0 (see #657):

DeprecationWarning: 
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
but was not found to be installed on your system.
If this would cause problems for you,
please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466

However, from reading issue pandas-dev/pandas#54466 which is collating community feedback, concerns were raised about the increased footprint from installing pyarrow.

Subsequently, this DeprecationWarning was removed in pandas patch release 2.2.1 and included as an optional install i.e., pip install pandas[pyarrow] (see here and here).

As a result, we can drop the inclusion of pyarrow, which is also a blocker in our py313 support (see here) 🙏


@github-actions github-actions bot added the type: dependencies Auto-labelled label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (81bbca0) to head (7c58ee8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1178   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          58       58           
  Lines        2939     2939           
=======================================
  Hits         2683     2683           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle merged commit cd220bd into main Oct 28, 2024
23 checks passed
@bjlittle bjlittle deleted the drop-optional-pyarrow branch October 28, 2024 14:28
@bjlittle
Copy link
Owner Author

Reference #1179

Removing pyarrow has resulted in a reduction of 38 packages from both the py311 and py312 environments 🥳

... and we can also resolve a full developer py313 environment for the first time 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant