Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran dotnet format #5218

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Ran dotnet format #5218

merged 2 commits into from
Jan 3, 2025

Conversation

cturnbull-bitwarden
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.68%. Comparing base (f74b94b) to head (257a132).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Services/Implementations/UserService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5218   +/-   ##
=======================================
  Coverage   43.68%   43.68%           
=======================================
  Files        1469     1469           
  Lines       67885    67885           
  Branches     6153     6153           
=======================================
  Hits        29658    29658           
  Misses      36934    36934           
  Partials     1293     1293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cturnbull-bitwarden cturnbull-bitwarden merged commit 4871f0b into main Jan 3, 2025
53 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/format branch January 3, 2025 21:00
cturnbull-bitwarden added a commit that referenced this pull request Jan 3, 2025
* Ran `dotnet format`

* Re-added usings

(cherry picked from commit 4871f0b)
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Logo
Checkmarx One – Scan Summary & Details17473b05-870b-40ff-880d-0b17a1afd076

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants