-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRE-292: Sync ephemeral environment with GH workflow #5174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5174 +/- ##
==========================================
+ Coverage 42.92% 43.34% +0.42%
==========================================
Files 1433 1458 +25
Lines 65672 66517 +845
Branches 6022 6081 +59
==========================================
+ Hits 28191 28835 +644
- Misses 36215 36390 +175
- Partials 1266 1292 +26 ☔ View full report in Codecov by Sentry. |
vgrassia
requested changes
Jan 2, 2025
Co-authored-by: Vince Grassia <[email protected]>
vgrassia
approved these changes
Jan 2, 2025
addisonbeck
approved these changes
Jan 2, 2025
mimartin12
added a commit
that referenced
this pull request
Jan 2, 2025
* Add sync_environment call * Put callable workflow in it's own job * Switch to context for GitHub input * Set requirements and inherit secrets * Add the condition to the job * Update .github/workflows/build.yml Co-authored-by: Vince Grassia <[email protected]> --------- Co-authored-by: Vince Grassia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-292
📔 Objective
Adds a job that will run when the ephemeral environment label exists on the pull request. This calls the reusable workflow in the gh-actions repository which will sync the ephemeral environment. This provides a status via the "check" section of the pull request.
An example can be seen here: https://github.com/bitwarden/server/actions/runs/12551766534/job/34996863441
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes