Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-292: Sync ephemeral environment with GH workflow #5174

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

mimartin12
Copy link
Contributor

@mimartin12 mimartin12 commented Dec 20, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-292

📔 Objective

Adds a job that will run when the ephemeral environment label exists on the pull request. This calls the reusable workflow in the gh-actions repository which will sync the ephemeral environment. This provides a status via the "check" section of the pull request.

An example can be seen here: https://github.com/bitwarden/server/actions/runs/12551766534/job/34996863441

📸 Screenshots

Screenshot 2024-12-30 at 1 57 01 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Logo
Checkmarx One – Scan Summary & Detailsb63d3e65-9ac0-4091-98d7-e9c5e953b683

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-21538 Npm-cross-spawn-7.0.3 Vulnerable Package
MEDIUM CVE-2024-55565 Npm-nanoid-3.3.7 Vulnerable Package

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 967
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 67
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 61
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 967
LOW Unsafe_Use_Of_Target_blank /src/Core/MailTemplates/Handlebars/OrganizationDomainUnclaimed.html.hbs: 20

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.34%. Comparing base (94761a8) to head (4bd5e18).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5174      +/-   ##
==========================================
+ Coverage   42.92%   43.34%   +0.42%     
==========================================
  Files        1433     1458      +25     
  Lines       65672    66517     +845     
  Branches     6022     6081      +59     
==========================================
+ Hits        28191    28835     +644     
- Misses      36215    36390     +175     
- Partials     1266     1292      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mimartin12 mimartin12 requested a review from a team December 30, 2024 21:01
@mimartin12 mimartin12 marked this pull request as ready for review December 30, 2024 21:01
@mimartin12 mimartin12 requested a review from a team as a code owner December 30, 2024 21:01
@mimartin12 mimartin12 requested a review from vgrassia January 2, 2025 18:29
@mimartin12 mimartin12 merged commit 840ff00 into main Jan 2, 2025
52 checks passed
mimartin12 added a commit that referenced this pull request Jan 2, 2025
* Add sync_environment call

* Put callable workflow in it's own job

* Switch to context for GitHub input

* Set requirements and inherit secrets

* Add the condition to the job

* Update .github/workflows/build.yml

Co-authored-by: Vince Grassia <[email protected]>

---------

Co-authored-by: Vince Grassia <[email protected]>
@mimartin12 mimartin12 deleted the BRE-292-sync-ephemeral-env-on-build branch January 2, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants