Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HasShieldFormComponents.php #476

Open
wants to merge 3 commits into
base: 3.x
Choose a base branch
from

Conversation

stevefontaine
Copy link

When we try to set the checkbox settings on the resource, it only takes into account the general checkbox colums setting and not the particular one for the resources.

This PR should fix this

Duplicated the method getCheckboxListFormComponent() into a new one getCheckboxListFormComponentForResource() and added the getResourceCheckboxListColumns()

to fix the resourceCheckboxColums not being taken into account.
Copy link

what-the-diff bot commented Dec 30, 2024

PR Summary

  • Method Call Update in getCheckboxListComponentForResource
    The existing instruction for this module was upgraded to improve its functionality. Previously, it was using a less specialized procedure called getCheckboxListFormComponent, but now it has been adapted to a more directed method getCheckboxListFormComponentForResource that brings better utility for resources.

  • Addition of a new Public Static Method
    A new technique, named getCheckboxListFormComponentForResources, was added. This creates a list that users can select options from, and comes with additional setup options including searchability and managing the status of elements, making it easier for users to find what they need and keep track of their selections. This means a better experience for users when dealing with multiple option selections.

@stevefontaine
Copy link
Author

Sorry I just tested it and if fails. Should have tested it before submitting my bad !

@stevefontaine
Copy link
Author

Well, just made a typo in the new method name:
Instead of getCheckboxListFormComponentForResources()
need to change for getCheckboxListFormComponentForResource() (singular)

@bezhanSalleh
Copy link
Owner

i'm not sure what you mean by "When we try to set the checkbox settings on the resource, it only takes into account the general checkbox colums setting and not the particular one for the resources." could you add visually depict the issue you are trying to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants