Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docuseal #851

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Add docuseal #851

merged 2 commits into from
Jan 5, 2025
+101 −1

Conversation

meonkeys
Copy link
Contributor

Description

Add Docuseal smart card.

Fixes #847

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers. not checking this off because I have done only minimal testing
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@meonkeys
force response to text if not json
1bd10a5 
Without that I'm getting Version "[object Response]" on the smart card
from an api that returns text/plain.

See bastienwirtz#847 - add Docuseal (requires text/plain support or hack)
@meonkeys
add Docuseal smart card
911cdec 
Fixes bastienwirtz#847

Requires bastienwirtz#850
@meonkeys meonkeys mentioned this pull request Dec 29, 2024
Closed
7 tasks
bastienwirtz
bastienwirtz approved these changes Dec 30, 2024
View reviewed changes
src/components/services/Docuseal.vue Show resolved Hide resolved
src/mixins/service.js Show resolved Hide resolved
@bastienwirtz bastienwirtz merged commit 66d4cc3 into bastienwirtz:main Jan 5, 2025
6 checks passed
@meonkeys meonkeys deleted the add-docuseal branch January 5, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastienwirtz bastienwirtz bastienwirtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Docuseal (requires text/plain support or hack)
2 participants
@meonkeys @bastienwirtz