Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Loot) Sealed Craftsman's Writ loot problem #20981

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Exitare
Copy link
Member

@Exitare Exitare commented Dec 20, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Dec 20, 2024
@Exitare Exitare changed the title Fix Sealed Craftsman's Writ loot problem fix(DB/Loot) Sealed Craftsman's Writ loot problem Dec 22, 2024
@TheSCREWEDSoftware
Copy link
Contributor

I've tested this and i'm unable to reproduce the issue so it fixes and is working.

But I would pressume all Craftsman's Writ items should follow custom flag as others (2 Ignore_quest_status)

If you run this query

SELECT * FROM `item_template` WHERE (`name` LIKE '%Craftsman\'s Writ -%') AND `flagsCustom` = 0 AND `class` = 12

You will see 3 entries that werent changed with your query.

entry name
22619 Craftsman's Writ - Greater Frost Protection Potion
22625 Craftsman's Writ - Baked Salmon
22626 Craftsman's Writ - Runn Tum Tuber Surprise

@TheSCREWEDSoftware TheSCREWEDSoftware added Tested This PR has been tested and is working. and removed Waiting to be Tested labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Tested This PR has been tested and is working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Loot table problem] Sealed Craftsman's Writ
4 participants