-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edited documentation and removed SMTP configs from env #66
base: master
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughThe recent changes involve the removal of several SMTP-related configuration settings from the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified that smtp setup still works and that proper envs are being removed. LGTM. Will want to verify one more time once both changes are merged in
Description
This resolves #2177. With the recent change, SMTP configs are no longer taken from the env file but are configured using the UI and saved in the config. For more information see #2168. This PR removes the following from the env file and docker compose file.
HOST_PROTOCOL
HOST_DOMAIN
SMTP_SETTINGS_ADDRESS
SMTP_SETTINGS_PORT
SMTP_SETTINGS_ENABLE_STARTTLS_AUTO
SMTP_SETTINGS_AUTHENTICATION
SMTP_SETTINGS_USER_NAME
SMTP_SETTINGS_PASSWORD
SMTP_SETTINGS_DOMAIN
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting