Auto-create and reuse bot-owned webhooks (#59)

* Auto-create and reuse bot-owned webhooks

* Update README.md WRT webhooks

* Add webstorm ignore to .gitignore

* Add WebStorm configuration

.gitignore

@@ -8,6 +8,11 @@ discord-irc
 logs
 *.log
 
+# WebStorm
+**/.idea/workspace.xml
+**/.idea/tasks.xml
+**/.idea/discord.xml
+
 # Runtime data
 pids
 *.pid

README.md

@@ -220,10 +220,8 @@ First you need to create a Discord bot user, which you can do by following the i
     "discord": ["discord_nick1", "discord_nick2"], // Ignore specified Discord nicks and do not send their messages to IRC.
     "discordIds": ["198528216523210752"] // Ignore specified Discord ids and do not send their messages to IRC.
   },
-  // List of webhooks per channel
-  "webhooks": {
-    "#discord": "https://discord.com/api/webhooks/id/token"
-  },
+  // Use webhooks
+  "webhooks": true,
   // Commands that will be sent on connect
   // Note: these are typically optional and only provided as a reference
   "autoSendCommands": [
@@ -247,16 +245,14 @@ Webhooks lets you override nicknames and avatars, so messages coming from IRC ca
 
 ![discord-webhook](http://i.imgur.com/lNeJIUI.jpg)
 
-To enable webhooks, follow part 1 of
-[this guide](https://support.discord.com/hc/en-us/articles/228383668-Intro-to-Webhooks) to create and retrieve a webhook
-URL for a specific channel, then enable it in discord-irc's config as follows:
+To enable webhooks, enable them in discord-irc's config as follows:
 
 ```json
-"webhooks": {
-  "#discord-channel": "https://discord.com/api/webhooks/id/token"
-}
+"webhooks": true
 ```
 
+The bot will automatically create and re-use its own webhooks.
+
 ## Tests (TODO)
 
 Run the tests with:

lib/channelMapping.ts

@@ -40,16 +40,15 @@ export class ChannelMapper {
       }
       // Check for webhook
       let webhookURL: string | null = null;
-      if (config.webhooks) {
-        if (config.webhooks['#' + discordChannel.name]) {
-          webhookURL = config.webhooks['#' + discordChannel.name];
-        } else if (config.webhooks[discordChannel.id]) {
-          webhookURL = config.webhooks[discordChannel.id];
-        }
-      }
       let client: Webhook | null = null;
-      if (webhookURL) {
-        client = await Webhook.fromURL(webhookURL, discord);
+      if (config.webhooks) {
+        const hookName = `${bot.config.nickname}_${discordChannel.name}`;
+        const hooks = await discordChannel.fetchWebhooks();
+        const hook = hooks.find((h) => h.name === hookName);
+        client = hook ?? await Webhook.create(discordChannel, discord, {
+          name: hookName,
+        });
+        webhookURL = client.url;
       }
       const mapping: ChannelMapping = {
         discordChannel: discordChannel,

lib/config.ts

@@ -49,7 +49,7 @@ export type Config = {
   parallelPingFix?: boolean;
   ircStatusNotices?: boolean;
   announceSelfJoin?: boolean;
-  webhooks?: Dictionary<string>;
+  webhooks?: boolean;
   ignoreUsers?: IgnoreUsers;
   gameLogConfig?: GameLogConfig;
   ignoreConfig?: IgnoreConfig;
@@ -116,7 +116,7 @@ export const ConfigSchema = z.object({
   parallelPingFix: z.boolean().optional(),
   ircStatusNotices: z.boolean().optional(),
   announceSelfJoin: z.boolean().optional(),
-  webhooks: z.record(z.string()).optional(),
+  webhooks: z.boolean().optional(),
   ignoreUsers: IgnoreUsersSchema.optional(),
   gameLogConfig: GameLogConfigSchema.optional(),
   ignoreConfig: IgnoreConfigSchema.optional(),