-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): Add health checks for CustomResourceDefinitions (CRDs) #21323
Open
chansuke
wants to merge
9
commits into
argoproj:master
Choose a base branch
from
chansuke:feat/health-status-customization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(controller): Add health checks for CustomResourceDefinitions (CRDs) #21323
chansuke
wants to merge
9
commits into
argoproj:master
from
chansuke:feat/health-status-customization
+112
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chansuke <[email protected]>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
feat/health-status-customization
branch
from
December 29, 2024 11:58
f2bd4f7
to
b938ca4
Compare
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
feat/health-status-customization
branch
from
December 29, 2024 13:29
7305314
to
adbf586
Compare
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
feat/health-status-customization
branch
from
December 29, 2024 13:55
79715bd
to
8c71fb8
Compare
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
feat/health-status-customization
branch
from
December 30, 2024 05:33
47974ac
to
4b95de7
Compare
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
feat/health-status-customization
branch
from
December 30, 2024 05:37
4b95de7
to
6680ca0
Compare
nitishfy
suggested changes
Jan 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the failing tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21119
Checklist: