Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Add health checks for CustomResourceDefinitions (CRDs) #21323

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

chansuke
Copy link
Contributor

Closes #21119

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Dec 29, 2024

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: chansuke <[email protected]>
@chansuke chansuke force-pushed the feat/health-status-customization branch from f2bd4f7 to b938ca4 Compare December 29, 2024 11:58
Signed-off-by: chansuke <[email protected]>
@chansuke chansuke force-pushed the feat/health-status-customization branch from 7305314 to adbf586 Compare December 29, 2024 13:29
Signed-off-by: chansuke <[email protected]>
@chansuke chansuke force-pushed the feat/health-status-customization branch from 79715bd to 8c71fb8 Compare December 29, 2024 13:55
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
@chansuke chansuke force-pushed the feat/health-status-customization branch from 47974ac to 4b95de7 Compare December 30, 2024 05:33
Signed-off-by: chansuke <[email protected]>
@chansuke chansuke force-pushed the feat/health-status-customization branch from 4b95de7 to 6680ca0 Compare December 30, 2024 05:37
@chansuke chansuke marked this pull request as ready for review December 30, 2024 07:19
@chansuke chansuke requested a review from a team as a code owner December 30, 2024 07:19
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the failing tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health status customization in Argo for CRD resources
2 participants