Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable use-any from revive #21282

Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 21, 2024

Description

revive helps ensure a number of rules

use-any proposes to replace instances of interface{} with any.

By default revive has a list of rules enabled. This includes this list and disables those that are not yet applied.

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 21, 2024 09:02
Copy link

bunnyshell bot commented Dec 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 86.03945% with 92 lines in your changes missing coverage. Please review.

Project coverage is 53.28%. Comparing base (8126508) to head (9e041e4).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/application/forwarder_overwrite.go 31.81% 15 Missing ⚠️
cmd/argocd-dex/commands/argocd_dex.go 0.00% 7 Missing ⚠️
server/application/application.go 63.63% 4 Missing ⚠️
util/clusterauth/clusterauth.go 55.55% 0 Missing and 4 partials ⚠️
util/grpc/errors.go 0.00% 4 Missing ⚠️
util/grpc/grpc.go 33.33% 3 Missing and 1 partial ⚠️
util/kustomize/kustomize.go 63.63% 4 Missing ⚠️
util/settings/settings.go 80.00% 4 Missing ⚠️
applicationset/utils/map.go 40.00% 3 Missing ⚠️
pkg/apiclient/grpcproxy.go 0.00% 3 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21282      +/-   ##
==========================================
- Coverage   55.19%   53.28%   -1.92%     
==========================================
  Files         337      337              
  Lines       57058    57058              
==========================================
- Hits        31496    30403    -1093     
- Misses      22863    24000    +1137     
+ Partials     2699     2655      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive/use-any branch 2 times, most recently from 61ed376 to 4972abf Compare December 26, 2024 20:33
@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive/use-any branch 3 times, most recently from f09552b to 3f69bdd Compare December 30, 2024 17:25
@mmorel-35 mmorel-35 marked this pull request as draft December 30, 2024 19:10
@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive/use-any branch from 3f69bdd to 7864b37 Compare December 30, 2024 19:31
@mmorel-35 mmorel-35 marked this pull request as ready for review December 30, 2024 19:35
@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive/use-any branch from 7864b37 to 9e041e4 Compare December 31, 2024 09:25
@andrii-korotkov-verkada
Copy link
Contributor

Idk, I kinda like interface{}. I don't think we should enforce the usage of any.

@crenshaw-dev
Copy link
Member

I'm fine either way. I am curious why the changes to openapi_generated.go aren't causing CI failures.

@crenshaw-dev
Copy link
Member

Figured that out: #21350

I like any, probably not worth too much back and forth over it. Can revert if there are major concerns later.

@crenshaw-dev crenshaw-dev merged commit 9ea979b into argoproj:master Jan 2, 2025
27 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/revive/use-any branch January 3, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants