Reduce Publisher/Single retry/repeat allocations #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RepeatWhenSingle was recently introduced and avoids allocating new Subscribers for each repeat operation. This helps save object allocation when the operator is used in a loop. We should use a consistent strategy for existing Publisher/Single repeat/retry related operators. Modifications: - Redo[When]Publisher and Retry[When]Single no longer allocates a new Subscriber on each iteration. - All the repeat/retry operators now have consistent behavior for AsyncContext map which is to re-use it. Previously a copy was made before resubscribing, however the old map is no longer used after a terminal event anyways so this shouldn't have any benefit. Either we copy the map up front before subscribe, or we just re-use the same map and let the async source at the top of the chain reset if necessary. Result: Less object allocation and consistent AsyncContext behavior for repeat/retry operators.
|
build failure attributed to #1894 |
idelpivnitskiy
approved these changes
Mar 1, 2022
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/RedoPublisher.java
Show resolved
Hide resolved
|
|
build failure attributed to #2069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RepeatWhenSingle was recently introduced and avoids allocating
new Subscribers for each repeat operation. This helps save
object allocation when the operator is used in a loop. We
should use a consistent strategy for existing Publisher/Single
repeat/retry related operators.
Modifications:
a new Subscriber on each iteration.
for AsyncContext map which is to re-use it. Previously a copy
was made before resubscribing, however the old map is no longer
used after a terminal event anyways so this shouldn't have any
benefit. Either we copy the map up front before subscribe, or
we just re-use the same map and let the async source at the top
of the chain reset if necessary.
Result:
Less object allocation and consistent AsyncContext behavior for
repeat/retry operators.