Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rule for meineschufa.de #835

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Added rule for meineschufa.de #835

merged 2 commits into from
Oct 15, 2024

Conversation

hatobi
Copy link
Contributor

@hatobi hatobi commented Oct 15, 2024

Added password rules for meineschufa.de

The website is in German but the rules, as spelled out on the website, are:

  • at least 10 characters
  • at least 1 digit
  • at least 1 uppercase character
  • at least 1 lowercase character
  • at least 1 of the special characters ! ? # % $
  • no other special characters
  • no spaces
2024-10-15_153446_Screenshot

Passwords generated by the Password Rules Validation Tool have been successfully tested.

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

hatobi and others added 2 commits October 15, 2024 15:31
All required classes are also allowed, so remove this unnecessary allow clause.
@rmondello rmondello merged commit 1bafca0 into apple:main Oct 15, 2024
5 checks passed
@rmondello
Copy link
Contributor

@hatobi I made a small change, which hopefully makes sense! Thank you for your contribution!

@hatobi
Copy link
Contributor Author

hatobi commented Oct 15, 2024

@rmondello thanks a lot for your correction, definitely makes sense! Sorry for the redundancy.

@rmondello
Copy link
Contributor

@hatobi No problem! That's what we're here for!

rmondello added a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
* Added rule for meineschufa.de

* Update password-rules.json

All required classes are also allowed, so remove this unnecessary allow clause.

---------

Co-authored-by: Ricky Mondello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants