Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend gray failure recentHealthTriggeredRecoveryTime state to reflect any recovery #11839

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spraza
Copy link
Collaborator

@spraza spraza commented Dec 17, 2024

Extend gray failure recentHealthTriggeredRecoveryTime state to reflect any recovery, including non-gray failure triggered ones.

100K: 20241217-202817-praza-dd26679afd856420caeddc8c509783b1f2b233 compressed=True data_size=36247183 fail_fast=10 max_runs=100000 priority=100 sanity=False submitted=20241217-202817 timeout=5400 username=praza-dd26679afd856420caeddc8c509783b1f2b23302

Also explicitly ran fdbserver -r unittests -f /fdbserver/clustercontroller/ which includes gray failure unit tests, all pass.

TODO: kubernetes test

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@spraza spraza marked this pull request as draft December 17, 2024 20:19
…t any recovery, including non-gray failure triggered ones
@spraza spraza force-pushed the gray-failure-recovery-sync branch from 1cd2a88 to dd26679 Compare December 17, 2024 20:22
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: dd26679
  • Duration 0:04:45
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 1cd2a88
  • Duration 0:09:06
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 1cd2a883000a867ca71ab8ae187ee616e8871363
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 1cd2a88
  • Duration 0:09:42
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 1cd2a883000a867ca71ab8ae187ee616e8871363
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 1cd2a88
  • Duration 0:09:44
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 1cd2a883000a867ca71ab8ae187ee616e8871363
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 1cd2a88
  • Duration 0:09:43
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 1cd2a883000a867ca71ab8ae187ee616e8871363
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 1cd2a88
  • Duration 0:09:43
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 1cd2a883000a867ca71ab8ae187ee616e8871363
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 1cd2a88
  • Duration 0:12:34
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 1cd2a883000a867ca71ab8ae187ee616e8871363
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 1cd2a88
  • Duration 0:13:06
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 1cd2a883000a867ca71ab8ae187ee616e8871363
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: dd26679
  • Duration 0:21:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: dd26679
  • Duration 1:00:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: dd26679
  • Duration 1:11:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: dd26679
  • Duration 1:18:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants