Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to set options for IUDPSocket. #11820

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wanghaEMQ
Copy link

This PR introduces three new methods to the IUDPSocket class.

setOptionReuseAddress
setOptionMulticastGroup
setOptionEnableLoopback

These methods are implemented in Net2.actor.cpp to enhance some popular functionality of UDP sockets. However, they are not implemented in sim2.actor.cpp because I’m unsure how to simulate these options in the simulation environment. Any guidance or feedback on how to address this would be greatly appreciated.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@wanghaEMQ
Copy link
Author

I also create a topic in foundationdb forum about adding interface set_option. https://forums.foundationdb.org/t/add-set-option-for-class-iudpsocket/4725. Any feedback or suggestion would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant