-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #249 #250
Fix #249 #250
Conversation
WalkthroughThe pull request introduces comprehensive documentation updates for the Apollo Configuration project's README.md. The changes focus on enhancing the configuration guidance by providing more detailed instructions for setting up the Apollo client. The documentation now includes expanded examples for configuring settings in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/Apollo.Configuration/README.md (2)
Line range hint
67-82
: Consider using consistent URL examples across documentation.The MetaServer URLs switch between using
localhost:8080
and IP addresses (81.68.181.139:8080
). Consider standardizing the examples to use consistent placeholder values for better readability.{ "apollo": { "Meta": { - "DEV": "http://81.68.181.139:8080/", - "FAT": "http://81.68.181.139:8080/", - "UAT": "http://81.68.181.139:8080/", - "PRO": "http://81.68.181.139:8080/" + "DEV": "http://apollo-configservice-dev:8080/", + "FAT": "http://apollo-configservice-fat:8080/", + "UAT": "http://apollo-configservice-uat:8080/", + "PRO": "http://apollo-configservice-pro:8080/" } } }
Line range hint
251-259
: Enhance security guidance for Secret configuration.While the Secret configuration is documented, consider adding:
- Best practices for managing secrets across different environments
- Warning about not storing secrets in version control
- Guidance on using secure secret management solutions
Consider adding the following section:
### Security Best Practices - Never commit secrets to version control - Use environment variables or secure secret management solutions in production - Consider using services like Azure Key Vault, AWS Secrets Manager, or HashiCorp Vault - Rotate secrets periodically and maintain an audit trail
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Apollo.Configuration/README.md
(1 hunks)
🔇 Additional comments (1)
src/Apollo.Configuration/README.md (1)
189-190
: LGTM! Good reordering of demo projects.
The new order better reflects modern deployment practices by presenting the environment variables configuration first, which is particularly relevant for containerized deployments.
Summary by CodeRabbit
README.md
with comprehensive configuration instructions for Apollo clientappsettings.json