[SPARK-50696][PYTHON] Optimize Py4J call for DDL parse method #49320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Dec 27, 2024
ueshin
approved these changes
Dec 28, 2024
zhengruifeng
changed the title
|
thanks, merged to master |
tedyu
reviewed
Dec 30, 2024
| } catch { | ||
| case _: Throwable => | ||
| try { | ||
| // For backwards compatibility, "fieldname: datatype, fieldname: datatype" case. |
There was a problem hiding this comment.
should we check for fieldname: datatype at the beginning so that the number of exceptions is reduced ?
Using exception is more expensive than checking.
val dataType = try {
if (ddl indexof "struct<" >= 0) return parseDataType(ddl)
if (ddl indexof ":" < 0 && ddl indexof ' ' < 0) return parseDataType(ddl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Optimize the DDL parse method in Python
Why are the changes needed?
to reduce the Py4J calls
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No