Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license declare for Nacos and its dependencies #21343

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

caqhy
Copy link
Contributor

@caqhy caqhy commented Oct 5, 2022

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Add license declare for Nacos and its dependencies

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have passed maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@caqhy
Copy link
Contributor Author

caqhy commented Oct 5, 2022

#20984

@caqhy caqhy marked this pull request as ready for review October 5, 2022 10:39
@strongduanmu strongduanmu added this to the 5.2.1 milestone Oct 6, 2022
@strongduanmu strongduanmu merged commit dcc9aea into apache:master Oct 6, 2022
@linghengqian
Copy link
Member

@caqhy
Copy link
Contributor Author

caqhy commented Oct 7, 2022

The reason for using nacos-client1. x instead of nacos-client2. x is registerInstance 注册覆盖前面的实例,不能注册多实例 #5863
At present, shardingsphere cluster mode repository nacos module uses NamingService, which is unreasonable. In the future, it needs to be switched to ConfigService. However, the configuration center features of nacos cannot fully implement ClusterPersistRepository. I have raised expectations to the nacos community.What features do you expect from Nacos 3.0? #9129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants