Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1131] test migration from V7 to code generation-34 #3653

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abhitocode
Copy link
Contributor

Below are the tests with issues, commented the same for each test.

  1. IntermediateEventTest
  • For tests,
    testIntermediateCatchEventCondition, testIntermediateCatchEventConditionFilterByProcessInstance, testConditionalBoundaryEventOnTaskComplete, testConditionalBoundaryEventInterrupting

for the tests with getKieSession,
How to add the person variable to the session? The model doesnot have the person field. Even after the person variable is added in the bpmn file, the test fails with a NPE,

When i try to complete workItem Im getting below error:

Caused by: java.lang.NullPointerException: Cannot invoke
"org.jbpm.process.instance.impl.AssignmentAction.execute(java.util.function.Function, java.util.function.Function, org.jbpm.process.instance.impl.AssignmentProducer)" because "action" is null at org.jbpm.workflow.core.impl.NodeIoHelper.handleAssignment(NodeIoHelper.java:113)
exception is this, org.jbpm.workflow.instance.WorkflowRuntimeException: [DataOutputAssociations:fa7cbf6e-fe07-408b-abcd-92ea30bed450 - Task:[uuid=_2]] -- java.lang.RuntimeException: Unable to execute Assignment

  1. StartEventTest
  • For *MultileStartEvent tests

we get below error:
org.kie.kogito.process.validation.ValidationException: A process cannot have more than one start node!

BPMN process definition includes multiple start events, but I if im not wrong Kogito seems to only support a single start node per process. Could you please clarify if there's a way to handle multiple start events within a single Kogito process definition or suggest an alternative approach ?

guidance on above would be helpful.

Closes apache/incubator-kie-issues#1131.

Note: This pr contains tests with error, only for review purpose.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 29, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3653 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3653/1/display/redirect

Test results:

  • PASSED: 3233
  • FAILED: 2

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventCondition
expected: 1
but was: 5
org.jbpm.bpmn2.StartEventTest.testMultipleStartEventsRegularStart A process cannot have more than one start node!

@elguardian elguardian added the question Further information is requested label Aug 30, 2024
@elguardian
Copy link
Contributor

the test here cannot be migrated due to kie session not working on kogito.

@elguardian elguardian self-requested a review September 16, 2024 06:40
@elguardian
Copy link
Contributor

this requires a prior fix to condition activation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate process test migration from v7 legacy runtime to code generation
3 participants