Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText #20615

Closed
wants to merge 1 commit into from

Conversation

XHL-study
Copy link

@XHL-study XHL-study commented Dec 23, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText

Fixed issues

#19966

Details

Before: What was the problem?

In previous versions, rich style did not work when using tooltip attribute renderMode=richText

After: How does it behave after the fixing?

Now, when using the tooltip attribute renderMode=richText, the rich style will achieve the expected effect.

example:
image

result as shown below:
image

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Dec 23, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link

echarts-bot bot commented Dec 23, 2024

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Dec 23, 2024
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit the changes under dist.

@XHL-study
Copy link
Author

Please don't commit the changes under dist.

I have modified

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way to support rich text. Consider checking out how title.textStyle does. And there is no good reason here using ts-ignore to ignore the typing problems.

This should be a new feature instead of a bug fixing because there isn't doc for rich now and you need to check "The document should be updated later".

Also, you should include test cases as according to the wiki.

@XHL-study
Copy link
Author

This is not the way to support rich text. Consider checking out how title.textStyle does. And there is no good reason here using ts-ignore to ignore the typing problems.

This should be a new feature instead of a bug fixing because there isn't doc for rich now and you need to check "The document should be updated later".

Also, you should include test cases as according to the wiki.

我需要重新提交一个feat吗。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants