-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText #20615
Conversation
Thanks for your contribution! |
Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't commit the changes under dist
.
…n tooltip is in renderMode=richText
9c74912
to
31be33d
Compare
I have modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the way to support rich text. Consider checking out how title.textStyle
does. And there is no good reason here using ts-ignore
to ignore the typing problems.
This should be a new feature instead of a bug fixing because there isn't doc for rich
now and you need to check "The document should be updated later".
Also, you should include test cases as according to the wiki.
我需要重新提交一个feat吗。。 |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed the problem that the rich style does not take effect when tooltip is in renderMode=richText
Fixed issues
#19966
Details
Before: What was the problem?
In previous versions, rich style did not work when using tooltip attribute renderMode=richText
After: How does it behave after the fixing?
Now, when using the tooltip attribute renderMode=richText, the rich style will achieve the expected effect.
example:
result as shown below:
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information