Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deserialize_to_struct example #13958

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 31, 2024

Which issue does this PR close?

Rationale for this change

While trying to find more examples to consolidate, I ran into this example which wasn't well documented and its description was mislableed

What changes are included in this PR?

  1. Fix description
  2. Update comments to explain what it was doing

Are these changes tested?

By CI

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review December 31, 2024 20:46
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

datafusion-examples/examples/deserialize_to_struct.rs Outdated Show resolved Hide resolved
datafusion-examples/examples/deserialize_to_struct.rs Outdated Show resolved Hide resolved
datafusion-examples/examples/deserialize_to_struct.rs Outdated Show resolved Hide resolved
@alamb
Copy link
Contributor Author

alamb commented Jan 3, 2025

Thank you @jonahgao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants