refactor/findDomNode #6805
Closed
refactor/findDomNode #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Deploying ant-design-mobile with
|
| Latest commit: |
09f568c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed3fddb8.ant-design-mobile.pages.dev |
| Branch Preview URL: | https://refactor-finddomnode.ant-design-mobile.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6805 +/- ##
==========================================
+ Coverage 92.72% 92.74% +0.02%
==========================================
Files 335 335
Lines 7198 7193 -5
Branches 1767 1802 +35
==========================================
- Hits 6674 6671 -3
+ Misses 516 514 -2
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
Size Change: -101 B (-0.03%) Total Size: 370 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
zombieJ
reviewed
Dec 30, 2024
| @@ -1,29 +1,29 @@ | |||
| import React from 'react' | |||
| import type { ReactNode } from 'react' | |||
| import { findDOMNode } from 'react-dom' | |||
There was a problem hiding this comment.
findDOMNode 是没有替代物的，如果换掉的话是会 break change 的
There was a problem hiding this comment.
findDOMNode是没有替代物的，如果换掉的话是会 break change 的
好, 那我等大版本规划在看看
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为了 react19 的适配做准备.
因发现
findDomNode将不再支持, 所以换了种获取实例的方式.通过增加一个同层级的
span获取兄弟节点赋值, 并将span设为display: none.