Add some dependencies to install and make every shell command copy-pastable #2682
Conversation
|
Last commit is there to include last changes from master branch |
|
Last commit is there to include last changes from master branch |
| $ ./configure --enable-utf8 --enable-geoip=mmdb | ||
| $ make | ||
| # make install | ||
| sudo apt install libncursesw5-dev libmaxminddb-dev |
There was a problem hiding this comment.
| sudo apt install libncursesw5-dev libmaxminddb-dev |
There was a problem hiding this comment.
I think it's best to keep this part distro-agnostic. We can emphasize the dependencies at the bottom, where they're already listed.
There was a problem hiding this comment.
I think that it's not the "straightforward way" to have all this deps in a table like this because per-distro commands to make things work are written above (and also I missed it... thx to point it out) maybe I missed something else but these deps are not "optional" because without it the software do not compile.
But I also agree with your way to see things. Thx for your beautiful software BTW :)
When I needed to install goaccess the make step failed because of missing dependencies (maxmind and ncurses), so I added it in README in the style Debian style.
Then I also wish to have every command copy-pastable without removing the "$" or "#" char so I remove it and add it for the real comments.