Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug. The parameter --keep_last_n_checkpoints -1 doesn't work. #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shizhengLi
Copy link

Modify logic of clean_last_n_checkpoints method in utils.py file.

@vwxyzjn
Copy link
Collaborator

vwxyzjn commented Dec 3, 2024

Thanks for the PR. What is the meaning of --keep_last_n_checkpoints -1?

@shizhengLi
Copy link
Author

Hi, in the open-instruct/open_instruct/finetune.py file, there is a parameter:
keep_last_n_checkpoints: int = field( default=3, metadata={"help": "How many checkpoints to keep in the output directory. -1 for all."}, )

--keep_last_n_checkpoints -1 means keeping all the checkpoints. When I set it, it didn't work, so I just fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants