-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCLM Style Deduplications #214
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run make style to pass the linter and style check . Also, please add tests in https://github.com/allenai/dolma/blob/main/tests/python/test_deduper.py
@@ -108,7 +127,7 @@ class DeduperConfig: | |||
dedupe: DedupeConfig = field(help="Deduplication configuration. Required.") | |||
bloom_filter: BloomFilterConfig = field(help="Bloom filter configuration. Required.") | |||
processes: int = field( | |||
default=1, help="Number of processes to use for deduplication. If 1, no multiprocessing will be used." | |||
default=0, help="Number of processes to use for deduplication. If 1, no multiprocessing will be used." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 => means we do the max parallelism (processes becomes number of cores available). I just assumed that we want this behavior almost all of the time
This might not actually play nice with beaker nodes and how CPU's get allocated here. I'll fall back on ai2-best-practices here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the help string to reflect this since it's non-obvious
General updates to the
dedupe
command to do deduplication using a joint paragraph/document flow in the same way that DCLM does.Nuanced update list:
Bloom Filter updates:
Deduper updates:
Other stuff: