-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: support resolving JAVA_HOME from symbolic links when `which… #12982
base: develop
Are you sure you want to change the base?
Conversation
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12982 +/- ##
=============================================
- Coverage 72.28% 72.28% -0.01%
Complexity 9999 9999
=============================================
Files 1309 1309
Lines 41991 41991
Branches 4405 4405
=============================================
- Hits 30353 30352 -1
- Misses 9514 9516 +2
+ Partials 2124 2123 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
gh pr checkout 12982 |
Please sign cla first |
|
… java` is used
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
This change optimizes the logic for detecting JAVA_HOME in the Nacos startup script. Specifically, it adds support for resolving JAVA_HOME from symbolic links when the which java command is used. This enhancement ensures compatibility with systems where JAVA_HOME is not explicitly set but java is available via a symbolic link.
Brief changelog
Verifying this change
To verify this change:
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.