Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Analysis of relative links #433

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

IgorA100
Copy link
Contributor

@IgorA100 IgorA100 commented Dec 23, 2024

  1. Fix: Relative links #419 - partially corrupted the formation of Link for the Atom feed.
    I learned about this only the day before yesterday and urgently made this PR.

  • Fix: Error preg_replace(), add all other possible replacements for relative links.
  • Replaced links like href="#aaa/bbb.xxx"
  • Replaced links like href="aaa/bbb.xxx"

This PR is a more correct replacement for #426
Similar to #427 #431

1 Cannot use the "Link" object to analyze relative links
Because the "Link" for the Atom feed will be corrupted.
Use the additionally created "LinkForAnalysis" object

2. 
- Fix: Error preg_replace(), add all other possible replacements for relative links.
- Replaced links like href="#aaa/bbb.xxx"
- Replaced links like href="aaa/bbb.xxx"
Similar to alexdebril#427
@IgorA100 IgorA100 marked this pull request as ready for review December 23, 2024 07:23
@IgorA100 IgorA100 requested a review from alexdebril as a code owner December 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant