Impl PublishWithContext and make subscriber and publisher accessible #2882
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made subscriber and publisher package private. In case when you need custom approach or just client
|
Hi @bc-tayvs, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
patriknw
reviewed
Aug 17, 2022
| @@ -127,15 +140,28 @@ object GooglePubSub { | |||
| .mapMaterializedValue(_.flatMap(identity)(ExecutionContexts.parasitic)) | |||
| } | |||
|
|
|||
| private def publisher(mat: Materializer, attr: Attributes) = | |||
| @ApiMayChange | |||
There was a problem hiding this comment.
These are not supposed to be public user facing API? Then they should be marked with @InternalApi instead.
There was a problem hiding this comment.
I think they should be left private, or if I'm missing a use case, please describe it a bit.
| * | ||
| * @param parallelism controls how many messages can be in-flight at any given time | ||
| */ | ||
| def publishWithContext[Ctx](parallelism: Int): FlowWithContext[PublishRequest, Ctx, PublishResponse, Ctx, NotUsed] = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made subscriber and publisher package private. In case when you need custom approach or just client
Issue