Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resolves symlink on cd at zsh #777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dalton-oliveira
Copy link

Description

Having _ZO_RESOLVE_SYMLINKS env var defined as "1", makes zoxide to chase symink of directory before adding it to the database. This behavior can be more coherent if the cd command also does the same. That's specially useful for APFS which is case insensitive by default. Closes #740.

What was done

Adds CHASE_LINKS option to cd, the same one used in pwd on zsh.

@dalton-oliveira dalton-oliveira marked this pull request as draft April 1, 2024 13:22
@dalton-oliveira dalton-oliveira force-pushed the main branch 3 times, most recently from bc45490 to 41c0e82 Compare April 1, 2024 14:21
@dalton-oliveira dalton-oliveira marked this pull request as ready for review April 1, 2024 14:26
@dalton-oliveira dalton-oliveira force-pushed the main branch 2 times, most recently from 5f7493c to 333d624 Compare April 1, 2024 14:28
@dalton-oliveira
Copy link
Author

@ajeetdsouza thank you for this amazing tool! It has already saving me a lot of keystrokes. Hope this PR is adequate and thanks for taking a look.

@jesseleite
Copy link

Tested this branch using @dalton-oliveira's instructions here and it seems to totally fix my issue in #740 😍

@ajeetdsouza
Copy link
Owner

@dalton-oliveira just one question - why do we not use cd -P on Windows?

@dalton-oliveira
Copy link
Author

@ajeetdsouza I was concerned to break something that I couldn't check manually. Just removed the conditional

@jesseleite
Copy link

Thanks for doing this @dalton-oliveira! ❤️

@jesseleite
Copy link

jesseleite commented Apr 29, 2024

Just tested again since that last commit. Still works great / fixes my MacOS case sensitivity issues in #740 👍

@duncanmcclean
Copy link

I have a similar issue to @jesseleite - would love to see this merged! 😄

@dalton-oliveira
Copy link
Author

Hey @ajeetdsouza have just rebased with main. It's been here for a while so please feel free to reject the PR if you doesn't intent to merge it :)

@jesseleite
Copy link

Thoughts on this one @ajeetdsouza? ...Would be huge little thing for us MacOS users, and it works great! 🙏🙏🙏

PS. Appreciate all you do! ❤️

@austenc
Copy link

austenc commented Oct 25, 2024

Just ran into this too, hope it gets merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-sensitivity issues with zoxide database?
5 participants