-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix resolves symlink on cd
at zsh
#777
base: main
Are you sure you want to change the base?
Conversation
bc45490
to
41c0e82
Compare
5f7493c
to
333d624
Compare
@ajeetdsouza thank you for this amazing tool! It has already saving me a lot of keystrokes. Hope this PR is adequate and thanks for taking a look. |
Tested this branch using @dalton-oliveira's instructions here and it seems to totally fix my issue in #740 😍 |
@dalton-oliveira just one question - why do we not use |
@ajeetdsouza I was concerned to break something that I couldn't check manually. Just removed the conditional |
Thanks for doing this @dalton-oliveira! ❤️ |
Just tested again since that last commit. Still works great / fixes my MacOS case sensitivity issues in #740 👍 |
I have a similar issue to @jesseleite - would love to see this merged! 😄 |
Hey @ajeetdsouza have just rebased with main. It's been here for a while so please feel free to reject the PR if you doesn't intent to merge it :) |
Thoughts on this one @ajeetdsouza? ...Would be huge little thing for us MacOS users, and it works great! 🙏🙏🙏 PS. Appreciate all you do! ❤️ |
Just ran into this too, hope it gets merged soon! |
Description
Having
_ZO_RESOLVE_SYMLINKS
env var defined as "1", makes zoxide to chase symink of directory before adding it to the database. This behavior can be more coherent if thecd
command also does the same. That's specially useful for APFS which is case insensitive by default. Closes #740.What was done
Adds
CHASE_LINKS
option tocd
, the same one used inpwd
on zsh.