Revert "RFC3986 compatible URL.join honoring empty segments (#1039)" #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
the
bot:chronographer:skip
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
- Coverage 62.60% 62.37% -0.24%
==========================================
Files 38 38
Lines 6721 6626 -95
Branches 368 356 -12
==========================================
- Hits 4208 4133 -75
+ Misses 2486 2466 -20
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
reviewed
Aug 31, 2024
| @@ -0,0 +1,3 @@ | |||
| Reverted RFC3986 compatible URL.join honoring empty segments which was introduced in :issue:`1039`. | |||
There was a problem hiding this comment.
@bdraco FYI, Sphinx has a dedicated role :rfc: which should be used to link RFCs. The rendered style would also be more consistent.
There was a problem hiding this comment.
I did discover that, and I changed it before I published it in the release step. At least I hope I did as my burnout level was pretty high at that point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e3dd736.
This change introduced a regression with parsing the query string in joined urls. #1066 attempted to fix the regression, but it became too involved. Since this doesn't look like there will be a quick fix, the change is being reverted so it can be tried again in the future.